-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store/tikv: move EtcdBackend out #22676
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
/run-all-tests |
/run-all-tests |
@youjiali1995, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIGs: execution(slack),sql-infra(slack). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
type EtcdBackend interface { | ||
EtcdAddrs() ([]string, error) | ||
TLSConfig() *tls.Config | ||
StartGCWorker() error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why StartGCWorker
is part of EtcdBackend
?
This reverts commit 7a275a7.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
EtcdBackend
interface is not used bystore/tikv
, so move it out.Part of #22513
Check List
Tests
Release note