Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: push aggregation operators down to projection by default #22090

Merged
merged 14 commits into from
Mar 17, 2021
Merged

planner: push aggregation operators down to projection by default #22090

merged 14 commits into from
Mar 17, 2021

Conversation

TszKitLo40
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #22072

Problem Summary:

What is changed and how it works?

What's Changed:
push aggregation operators down to projection and union by default
How it Works:
remove the check of AllowAggPushDown

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • No release note

@TszKitLo40 TszKitLo40 requested a review from a team as a code owner December 30, 2020 03:49
@TszKitLo40 TszKitLo40 requested review from SunRunAway and removed request for a team December 30, 2020 03:49
@TszKitLo40
Copy link
Contributor Author

/cc @qw4990

@TszKitLo40 TszKitLo40 marked this pull request as draft December 30, 2020 08:40
@SunRunAway SunRunAway requested review from winoros and removed request for SunRunAway December 31, 2020 10:02
@winoros
Copy link
Member

winoros commented Jan 8, 2021

Please fix the tests.
And this pr only dealt with Projection. Also I think we don't need consider UnionAll in this case.

A simple case is that

  • The union's sub child's NDV is large and their distribution is almost the same, we don't need to push it down.

@TszKitLo40 TszKitLo40 marked this pull request as ready for review January 8, 2021 09:48
@TszKitLo40
Copy link
Contributor Author

Please fix the tests.
And this pr only dealt with Projection. Also I think we don't need consider UnionAll in this case.

A simple case is that

  • The union's sub child's NDV is large and their distribution is almost the same, we don't need to push it down.

ok, I have done this, PTAL

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2021
@ti-srebot
Copy link
Contributor

@TszKitLo40, please update your pull request.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 2, 2021
@winoros winoros added the sig/planner SIG: Planner label Mar 2, 2021
winoros
winoros reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@winoros: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@winoros
Copy link
Member

winoros commented Mar 2, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2021
@ti-srebot
Copy link
Contributor

@TszKitLo40, please update your pull request.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2021
@TszKitLo40
Merge branch 'master' into issue22072
25a110c 
Signed-off-by: alfredlu <wslzj40@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2021
@TszKitLo40
Copy link
Contributor Author

@qw4990 PTAL

@winoros winoros changed the title planner: push aggregation operators down to projection and union by default planner: push aggregation operators down to projection by default Mar 16, 2021
@ti-srebot
Copy link
Contributor

@TszKitLo40, please update your pull request.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2021
@TszKitLo40
Merge branch 'master' into issue22072
87c07e1 
Signed-off-by: alfredlu <wslzj40@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2021
@qw4990
Copy link
Contributor

qw4990 commented Mar 17, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 87c07e1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2021
@TszKitLo40
Copy link
Contributor Author

/run-unit-test

1 similar comment
@TszKitLo40
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot
Copy link
Member

@TszKitLo40: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9f7ed0f into pingcap:master Mar 17, 2021
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@TszKitLo40 @SabaPing
planner: push aggregation operators down to projection by default (pi…
e640777 
…ngcap#22090)
@time-and-fate time-and-fate mentioned this pull request Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

push aggregation operators down to projection and union by default
6 participants
@TszKitLo40 @winoros @ti-srebot @ti-chi-bot @qw4990 @zz-jason