Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: update parser and add test for parse identifier #21908

Merged
merged 7 commits into from
Dec 24, 2020
Merged

parser: update parser and add test for parse identifier #21908

merged 7 commits into from
Dec 24, 2020

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number:
close #21677
close #3963

Check List

Tests

  • Unit test

Release note

  • fix a bug that parser will parse some SQL incorrect.

@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei
Merge remote-tracking branch 'upstream/master' into fix-lexer
8455393 
# Conflicts:
#	expression/integration_test.go
@xiongjiwei xiongjiwei marked this pull request as ready for review December 23, 2020 05:30
@xiongjiwei xiongjiwei requested a review from a team as a code owner December 23, 2020 05:30
@xiongjiwei xiongjiwei requested review from wshwsh12 and removed request for a team December 23, 2020 05:30
@xiongjiwei
Copy link
Contributor Author

@breeswish @wjhuang2016 PTAL

wjhuang2016
wjhuang2016 reviewed Dec 23, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2020
breezewish
breezewish approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 23, 2020
@ti-srebot
Copy link
Contributor

@xiongjiwei Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@xiongjiwei
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@wjhuang2016
Copy link
Member

/run-e2e

@wjhuang2016
Copy link
Member

/run-e2e-tests

@wjhuang2016 wjhuang2016 merged commit d337bf4 into pingcap:master Dec 24, 2020
Tjianke pushed a commit to Tjianke/tidb that referenced this pull request Dec 25, 2020
@xiongjiwei
parser: update parser and add test for parse identifier (pingcap#21908)
7dbded9
@xiongjiwei xiongjiwei deleted the up-parser branch December 29, 2020 03:48
@morgo morgo mentioned this pull request May 7, 2021
Closed
@xiongjiwei xiongjiwei mentioned this pull request May 8, 2021
Merged
@morgo morgo mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@breezewish breezewish breezewish approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

some sql stmt was parsed to wrong identifier select .78$123
4 participants
@xiongjiwei @ti-srebot @wjhuang2016 @breezewish