Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix comparing json with string #21903

Merged
merged 7 commits into from
Dec 23, 2020

Conversation

ichn-hu
Copy link
Contributor

@ichn-hu ichn-hu commented Dec 21, 2020

What problem does this PR solve?

Issue Number: close #11883 , also close #13710

Problem Summary:

What is changed and how it works?

What's Changed: remove Parse json tag

How it Works:

MySQL won't implicitly cast string to JSON during comparison.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test
    Side effects

Release note

  • No release note.

@ichn-hu ichn-hu requested a review from a team as a code owner December 21, 2020 09:25
@ichn-hu ichn-hu requested review from lzmhhh123 and removed request for a team December 21, 2020 09:25
@ichn-hu
Copy link
Contributor Author

ichn-hu commented Dec 21, 2020

/label needs-cherry-pick-4.0

@ichn-hu
Copy link
Contributor Author

ichn-hu commented Dec 21, 2020

/cc @XuHuaiyu

@ichn-hu ichn-hu mentioned this pull request Dec 21, 2020
@ichn-hu
Copy link
Contributor Author

ichn-hu commented Dec 22, 2020

@XuHuaiyu @lzmhhh123 PTAL

@ichn-hu
Copy link
Contributor Author

ichn-hu commented Dec 22, 2020

@XuHuaiyu @lzmhhh123 PTAL

@ichn-hu
Copy link
Contributor Author

ichn-hu commented Dec 22, 2020

/run-all-tests

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21832
  • 21849

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@ichn-hu merge failed.

@lzmhhh123 lzmhhh123 merged commit e172656 into pingcap:master Dec 23, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21958

Tjianke pushed a commit to Tjianke/tidb that referenced this pull request Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible issue related to JSON functions unexpect invalid json text error when query with json_extract
4 participants