Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: make txn entry size limit configurable #21843

Merged
merged 3 commits into from
Dec 25, 2020
Merged

kv: make txn entry size limit configurable #21843

merged 3 commits into from
Dec 25, 2020

Conversation

youjiali1995
Copy link
Contributor

@youjiali1995 youjiali1995 commented Dec 17, 2020 •
edited
Loading

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Make txn entry size limit configurable

Due to the limitation in memdb, the upper limit of this option is set to 120Mb

Related changes

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • make txn entry size limit configurable

@youjiali1995
kv: make txn entry size limit configurable
a1caecf 
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995 youjiali1995 added this to the v4.0.10 milestone Dec 23, 2020
@cfzjywxk
Copy link
Contributor

Should we add some documents to explain this parameter and some notes for example it's related with https://docs.pingcap.com/zh/tidb/dev/tikv-configuration-file#raft-entry-max-size.

@youjiali1995
Merge branch 'release-4.0' of https://github.com/pingcap/tidb into tx…
d010b3e 
…n-entry-size-limit-407

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995
Copy link
Contributor Author

Should we add some documents to explain this parameter and some notes for example it's related with https://docs.pingcap.com/zh/tidb/dev/tikv-configuration-file#raft-entry-max-size.

Yes

@youjiali1995
Copy link
Contributor Author

pingcap/docs-cn#5158

@cfzjywxk
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@TomShawn TomShawn mentioned this pull request Dec 24, 2020
Merged
9 tasks
@lysu
Copy link
Contributor

lysu commented Dec 24, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 24, 2020
@cfzjywxk
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 25, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@youjiali1995 merge failed.

@youjiali1995
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 8513c5e into pingcap:release-4.0 Dec 25, 2020
@youjiali1995 youjiali1995 deleted the txn-entry-size-limit-407 branch December 25, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

@coocood coocood Awaiting requested review from coocood

@jackysp jackysp Awaiting requested review from jackysp

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
component/config status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@youjiali1995 @cfzjywxk @lysu @ti-srebot @jackysp