Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check for decimal format in cast expr (#20836) #21476

Closed

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20836 to release-3.0


What problem does this PR solve?

Issue Number: close #20295

Problem Summary: There's no check for decimal format in cast expressions in TiDB.

select cast( (select sum(a) from t1) as decimal(65,65));
select CONVERT( 2, DECIMAL(62,60) ) ;
select CONVERT( 2, DECIMAL(66,29) ) ;

What is changed and how it works?

  • Check for decimal format in cast expressions during Preprocess.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Add checks for decimal format in cast expressions.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@dyzsr you're already a collaborator in bot's repo.

@dyzsr
Copy link
Contributor

dyzsr commented Dec 3, 2020

/run-all-tests

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2020
@dyzsr
Copy link
Contributor

dyzsr commented Dec 11, 2020

/run-all-tests

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 15, 2020
@jebter jebter modified the milestones: v3.0.20, v3.0.21 Jan 7, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jan 14, 2021

/run-all-tests

@zz-jason
Copy link
Member

close due to outdated, for now, we only cherry-pick critical bug-fixes to release-3.0

@zz-jason zz-jason closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants