ddl: fix a bug that doesn't add NoDefaultValueFlag when creating a table (#21468) #21474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/sql-infra
|
@wjhuang2016 you're already a collaborator in bot's repo. |
|
@bb7133 @wjhuang2016, could we merge this in v4.0.9 |
|
LGTM |
ti-srebot
added
status/LGT2
xiongjiwei
previously approved these changes
Dec 23, 2020
bb7133
approved these changes
Dec 23, 2020
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21468 to release-4.0
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #21465
Problem Summary:
NotNullFlag is added in setColumnFlagWithConstraint(), so processColumnFlags() can't see it. Then it won't add NoDefaultValueFlag.
What is changed and how it works?
Add NotNullFlag before calling processColumnFlags().
Related changes
Check List
Tests
Side effects
Release note