Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix sum(double) result if value is +Inf or -Inf (#21058) #21272

Merged
merged 6 commits into from
Nov 26, 2020
Merged

executor: fix sum(double) result if value is +Inf or -Inf (#21058) #21272

merged 6 commits into from
Nov 26, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21058 to release-4.0

What problem does this PR solve?

Issue Number: close #11208

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
insert into `t1` values (1, -1.7976931348623157e308),(2, -1.7976931348623157e308);
select * from t1;
select sum(md5int) from t1;

create table t2(id INT, md5int DOUBLE);
insert into `t2` values (1, 1.7976931348623157e308),(2, 1.7976931348623157e308);
select sum(md5int) from t2;

Side effects

Release note

  • No release note

@Win-Man @ti-srebot
cherry pick pingcap#21058 to release-4.0
6a5bd41 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 25, 2020
Merged
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

@Win-Man you're already a collaborator in bot's repo.

@Win-Man
Copy link
Contributor

Win-Man commented Nov 25, 2020

/run-all-tests

lzmhhh123
lzmhhh123 reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
SunRunAway
SunRunAway reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21161
  • 21236

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit d299e8f into pingcap:release-4.0 Nov 26, 2020
@tiancaiamao tiancaiamao deleted the release-4.0-1a91c1a10c35 branch November 26, 2020 05:52
This was referenced Dec 14, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@Win-Man Win-Man

Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @Win-Man @SunRunAway @tiancaiamao @lzmhhh123