executor: Fix IndexMergeReader works incorrectly under RC isolation level (#21208) #21253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/executor
sig/execution
|
@MyonKeminta you're already a collaborator in bot's repo. |
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
LGTM |
ti-srebot
added
status/LGT2
|
/merge |
|
Sorry @lzmhhh123, this branch cannot be merged without an approval of release maintainers |
SunRunAway
approved these changes
Nov 25, 2020
ti-srebot
added
status/LGT3
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21208 to release-4.0
What problem does this PR solve?
Issue Number: close #21151
Problem Summary: When IndexMerge is used in a RC transaction, it may not see the latest committed write, because it forgot
to refresh forUpdateTS..
What is changed and how it works?
What's Changed:
The
refreshForUpdateTSForRCinvoking is moved togetSnapshotTSfunction.A parameterThis is a try to avoid forgetting refreshing for update ts for new reader executors in the future.forTxnReadis added togetSnapshotTS, and when it's false it doesn't need to refresh it. So forChecksumTablethe ts refreshing can be skipped.Related changes
Check List
Tests
Release note