Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: ban (index) merge join heuristically when convert eq cond to other cond (#21138) #21146

Merged
merged 10 commits into from
Nov 25, 2020
Merged

planner: ban (index) merge join heuristically when convert eq cond to other cond (#21138) #21146

merged 10 commits into from
Nov 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21138 to release-4.0

… other cond

What problem does this PR solve?

Issue Number: close #20710

What is changed and how it works?

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • ban (index) merge join heuristically when convert equal conditions to other conditions.

@lzmhhh123 @ti-srebot
cherry pick pingcap#21138 to release-4.0
1f7db08 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Nov 19, 2020
Merged
@ti-srebot ti-srebot added sig/planner SIG: Planner type/4.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Nov 19, 2020
@ti-srebot ti-srebot added this to the v4.0.9 milestone Nov 19, 2020
@ti-srebot
Copy link
Contributor Author

@lzmhhh123 you're already a collaborator in bot's repo.

@lzmhhh123 lzmhhh123 mentioned this pull request Nov 23, 2020
Merged
@lzmhhh123
Copy link
Contributor

Wait for #21086 merged.

@lzmhhh123
Copy link
Contributor

conflicts resolved @SunRunAway @winoros

winoros
winoros reviewed Nov 25, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
@lzmhhh123 lzmhhh123 force-pushed the release-4.0-38bbb0dd2197 branch from 507f63d to c9373e4 Compare November 25, 2020 07:33
@github-actions github-actions bot added the sig/execution SIG execution label Nov 25, 2020
SunRunAway
SunRunAway approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 21176
  • 21171

SunRunAway
SunRunAway approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot merged commit abed326 into pingcap:release-4.0 Nov 25, 2020
@SunRunAway SunRunAway deleted the release-4.0-38bbb0dd2197 branch November 25, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@ichn-hu ichn-hu Awaiting requested review from ichn-hu

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@lzmhhh123 lzmhhh123

Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lzmhhh123 @SunRunAway @winoros