ddl: Fix partition value type check (#21016) #21136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
requested review from
bb7133,
crazycs520,
tiancaiamao,
wjhuang2016 and
xiongjiwei
|
@blacktear23 you're already a collaborator in bot's repo. |
Resolve the conflicts
|
LGTM |
|
LGTM |
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
bb7133
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21016 to release-4.0
What problem does this PR solve?
Issue Number: close #20979
Problem Summary:
Create partition table and the partition column values type not same as columns type can be succeeded.
What is changed and how it works?
What's Changed:
Add more type check for partition range or list values.
Related changes
Check List
Tests
Side effects
Release note