Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plannr: build empty range for overflow predicate #21042

Merged
merged 6 commits into from
Nov 16, 2020
Merged

plannr: build empty range for overflow predicate #21042

merged 6 commits into from
Nov 16, 2020

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #10448

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
As the title says

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

N/A

Release note

  • No release note

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner needs-cherry-pick-4.0 labels Nov 13, 2020
@XuHuaiyu XuHuaiyu requested review from qw4990 and lzmhhh123 November 13, 2020 07:53
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner November 13, 2020 07:53
@winoros
Copy link
Member

winoros commented Nov 13, 2020 •
edited
Loading

Can we deal with this before the construct ranges?
This filter should converted to false or just change the selection to TableDual directly whatever it can build range or not.

e.g. Check it when constructing the expression.

@XuHuaiyu
Copy link
Contributor Author

@winoros I'll check it

@ichn-hu ichn-hu mentioned this pull request Nov 13, 2020
Closed
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner November 13, 2020 08:19
@XuHuaiyu XuHuaiyu requested a review from winoros November 13, 2020 08:21
qw4990
qw4990 reviewed Nov 16, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2020
lzmhhh123
lzmhhh123 reviewed Nov 16, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 16, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit e90aac7 into pingcap:master Nov 16, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 16, 2020
@XuHuaiyu @ti-srebot
cherry pick pingcap#21042 to release-4.0
4c576de 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 16, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21073

XuHuaiyu pushed a commit that referenced this pull request Nov 17, 2020
@ti-srebot
plannr: build empty range for overflow predicate (#21042) (#21073)
4166dd3
@YangKeao YangKeao mentioned this pull request Feb 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unexpected behavior of float_col = int_cnst
5 participants
@XuHuaiyu @winoros @lzmhhh123 @ti-srebot @qw4990