planner: disable LOCK IN SHARE MODE by default (#19506) #21005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
sig/planner
ti-srebot
requested review from
cfzjywxk,
hanfei1991,
jackysp,
wshwsh12 and
zz-jason
|
@nullnotnil please resolve the code conflict. |
ghost
changed the title
ghost
force-pushed
the
release-4.0-9876de896127
branch
from
723c325
to
8d7f6ff
Compare
|
LGTM |
ti-srebot
added
status/LGT2
jackysp
approved these changes
Nov 17, 2020
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19506 to release-4.0
What problem does this PR solve?
Issue Number: fixes #19383
Problem Summary:
SELECT LOCK IN SHARE MODEis described in the manual as a noop. But that's not obvious to new users.This protects against incorrect usage via the enable_noop_functions flag; meaning that applications that want to execute the query and receive broken results have a way out.
(In the fix in master, this also disabled
SQL_CALC_FOUND_ROWSby default. But in this cherry-pick I've removed that, as I think it will break a lot more applications than are expected between point releases.)What is changed and how it works?
What's Changed:
Queries using LOCK IN SHARE MODE now get an error by default.
Related changes
Docs PR pingcap/docs#3898
Check List
Tests
Side effects
Release note
LOCK IN SHARE MODE. This helps alert users that this feature is not implemented by TiDB, but a workaround to restore the previous behavior is available by settingtidb_enable_noop_functions=1.