Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: generate proper hint for IndexHashJoin / IndexMergeJoin #20992

Merged
merged 3 commits into from
Nov 12, 2020
Merged

planner: generate proper hint for IndexHashJoin / IndexMergeJoin #20992

merged 3 commits into from
Nov 12, 2020

Conversation

eurekaka
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #20991

Problem Summary:

The join hint generated by explain format = 'hint' would not work if the join is index hash join or index merge join.

What is changed and how it works?

What's Changed:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Generate proper hint for IndexHashJoin / IndexMergeJoin`

@eurekaka eurekaka requested a review from a team as a code owner November 11, 2020 11:15
@eurekaka eurekaka requested review from XuHuaiyu and removed request for a team November 11, 2020 11:15
@eurekaka eurekaka requested review from winoros and qw4990 and removed request for XuHuaiyu November 11, 2020 12:07
winoros
winoros reviewed Nov 11, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2020
@eurekaka
Copy link
Contributor Author

@winoros @qw4990 please review the code changes and ignore the CI failures, they would be fixed once the parser PR is merged and go.mod is updated in TiDB.

@ichn-hu ichn-hu mentioned this pull request Nov 11, 2020
Closed
lzmhhh123
lzmhhh123 previously approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 12, 2020
ti-srebot
ti-srebot previously approved these changes Nov 12, 2020
View reviewed changes
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 12, 2020
@qw4990 qw4990 removed their request for review November 12, 2020 06:03
@eurekaka eurekaka dismissed stale reviews from ti-srebot and lzmhhh123 via 3a5ef87 November 12, 2020 07:05
@eurekaka
Copy link
Contributor Author

/run-all-tests

1 similar comment
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka merged commit 1804f4c into pingcap:master Nov 12, 2020
@eurekaka eurekaka deleted the join_hint branch November 12, 2020 09:29
@ti-srebot ti-srebot mentioned this pull request Nov 12, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21020

eurekaka added a commit to eurekaka/tidb that referenced this pull request Nov 27, 2020
@eurekaka
cherry pick pingcap#20992 to release-4.0
94f3dbb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@ti-srebot ti-srebot ti-srebot left review comments

Assignees
No one assigned
Labels
epic/sql-plan-management sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

explain format='hint' doesn't work for IndexHashJoin / IndexMergeJoin
4 participants
@eurekaka @ti-srebot @winoros @lzmhhh123