ddl: ignore integer zerofill size attribute when changing the column types #20862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AilinKid <314806019@qq.com>
bb7133
changed the title
bb7133
reviewed
Nov 5, 2020
bb7133
reviewed
Nov 5, 2020
AilinKid
added
type/bug
wjhuang2016
reviewed
Nov 5, 2020
tangenta
reviewed
Nov 10, 2020
ddl/column.go
Outdated
Comment on lines
696
to
698
| needTruncationOrToggleSignForInteger := func() bool { | ||
| return newColFlen > 0 && newColFlen < oldColFlen || toUnsigned != originUnsigned | ||
| } |
There was a problem hiding this comment.
Why not use a variable instead?
There was a problem hiding this comment.
Cause for most of the cases, we don't need to trigger the computation of it, like a kind of lazy call if necessary?
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
|
/run-all-tests |
|
LGTM |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 11, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 11, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #20986 |
bb7133
pushed a commit
that referenced
this pull request
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #20529
What is changed and how it works?
how does it work?
Like int(3), bigint(2), the number enclosed will be stored as
flenin the field type, while it shouldn't be concerned when we make column type change from int(3) to(2) . Because bigint is quite larger than int, there is no need to take a reorg process.what is changed
We should use the default
flenof the specified field type rather than the originflen.Check List
Tests
Release note