Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix the enum's default value where create table #20849

Merged
merged 7 commits into from
Nov 11, 2020
Merged

ddl: fix the enum's default value where create table #20849

merged 7 commits into from
Nov 11, 2020

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Nov 5, 2020 •
edited by bb7133
Loading

What problem does this PR solve?

Issue Number: close #11435

What is changed and how it works?

What's Changed:

refactor ParseSetName. add a new function ParseSet. ParseSetName only parse name.

How it Works:

add a function to handle enum type default value.

refers to #12267

Check List

Tests

  • Unit test

Release note

  • fix the issue that the default value of the enum column will be wrong if it is defined as an integer offset.

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Nov 5, 2020
@xiongjiwei xiongjiwei marked this pull request as ready for review November 5, 2020 03:23
@xiongjiwei xiongjiwei requested a review from a team as a code owner November 5, 2020 03:23
@xiongjiwei xiongjiwei requested review from XuHuaiyu and removed request for a team November 5, 2020 03:23
bb7133
bb7133 reviewed Nov 5, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
wjhuang2016
wjhuang2016 reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2020
@wjhuang2016
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 11, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@wjhuang2016
Copy link
Member

/run-unit-test

@wjhuang2016 wjhuang2016 merged commit e608e4b into pingcap:master Nov 11, 2020
@xiongjiwei xiongjiwei deleted the bug-11435 branch November 12, 2020 02:21
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CREATE TABLE interprets DEFAULT value incorrectly for enum columns
4 participants
@xiongjiwei @wjhuang2016 @ti-srebot @bb7133