Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, expression: set the evalType of hybrid type as ETInt in VecEvalBool (#20221) #20235

Merged
merged 1 commit into from
Sep 27, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #20221 to release-4.0


What problem does this PR solve?

Issue Number: close #20168

Problem Summary: enum value convert to float failed.

What is changed and how it works?

What's Changed:
Modify EvalExpr and VecEvalBool functions to support the hybrid type(ENUM/SET/BIT).

Check List

Tests

  • Unit test

Release note

  • Fix enum value convert to float failed

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor

LGTM

@ti-challenge-bot
Copy link

There is no reward for this challenge pull request, so you can request a reward from @XuHuaiyu.

More

Tip : About reward you can refs to reward-command.

Warning: None

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2020
@qw4990
Copy link
Contributor

qw4990 commented Sep 27, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @qw4990, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@qw4990 qw4990 merged commit d4c688f into pingcap:release-4.0 Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants