expression: fix a bug that from_unixtime + union all returns truncated result
#20225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ti-srebot
approved these changes
Sep 27, 2020
qw4990
added
the
status/can-merge
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-sqllogic-test-1 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #20240 |
zz-jason
pushed a commit
that referenced
this pull request
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #20223
Problem Summary:
For from_unixtime, Flen is set to the length of the second argument, which is not necessary.
What is changed and how it works?
Don't set flen.
Related changes
Check List
Tests
Side effects
Release note
from_unixtime+union allreturns truncated result