Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace: tee logs to runtime/trace output #19994

Merged
merged 9 commits into from
Sep 23, 2020
Merged

trace: tee logs to runtime/trace output #19994

merged 9 commits into from
Sep 23, 2020

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Sep 15, 2020 •
edited by ti-srebot
Loading

What problem does this PR solve?

Write logs into the output of runtime/trace. Because we often use trace to debug, it will write DEBUG level logs even if the global log level is not DEBUG.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

图片
图片

Release note

  • No release note

@bobotu bobotu added the type/enhancement The issue or PR belongs to an enhancement. label Sep 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Sep 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@bobotu
Copy link
Contributor Author

bobotu commented Sep 15, 2020

I'm refining the log format, don't merge for now.

@sre-bot
Copy link
Contributor

sre-bot commented Sep 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link
Contributor

sre-bot commented Sep 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@bobotu
Copy link
Contributor Author

bobotu commented Sep 15, 2020

/rebuild

@bobotu bobotu removed the status/DNM label Sep 15, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Sep 15, 2020

图片

@bobotu
Copy link
Contributor Author

bobotu commented Sep 15, 2020

PTAL @jackysp @lysu

@bobotu bobotu requested a review from a team as a code owner September 16, 2020 05:22
@bobotu bobotu requested review from lzmhhh123 and removed request for a team, crazycs520 and lzmhhh123 September 16, 2020 05:22
@bobotu
Copy link
Contributor Author

bobotu commented Sep 16, 2020

图片

@github-actions github-actions bot added the sig/execution SIG execution label Sep 16, 2020
jackysp
jackysp reviewed Sep 16, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2020
@wjhuang2016 wjhuang2016 mentioned this pull request Sep 17, 2020
Merged
@bobotu
Copy link
Contributor Author

bobotu commented Sep 18, 2020

PTAL @lysu

@bobotu
Copy link
Contributor Author

bobotu commented Sep 23, 2020

PTAL @lysu

@lysu
Copy link
Contributor

lysu commented Sep 23, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 23, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Sep 23, 2020

/merge

@ti-srebot
Copy link
Contributor

@bobotu Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@bobotu bobotu added the sig/transaction SIG:Transaction label Sep 23, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Sep 23, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 23, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 92a04ef into pingcap:master Sep 23, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 23, 2020
@ti-srebot
cherry pick pingcap#19994 to release-4.0
c98518c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 23, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20182

@bobotu bobotu deleted the log-trace-id branch September 23, 2020 11:08
ti-srebot added a commit that referenced this pull request Oct 3, 2020
@ti-srebot
trace: tee logs to runtime/trace output (#19994) (#20182)
81388ab 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees
No one assigned
Labels
sig/execution SIG execution sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobotu @sre-bot @lysu @ti-srebot @jackysp