Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: add new scalar function IsTruthWithNull (#19621) #19901

Merged
merged 9 commits into from
Sep 17, 2020
Merged

expression: add new scalar function IsTruthWithNull (#19621) #19901

merged 9 commits into from
Sep 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19621 to release-3.0

What problem does this PR solve?

Issue Number: close #17720, close #17476

Problem Summary: NewFunction can't get keepnull attributes for isture function.

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. Add a new scalar function name IsTruthWithNull in parser.
  2. Use the function name to build ScalarFuncton in wrapWithIsTrue.

How it Works:

Related changes

  • Need to cherry-pick to the release branch 3.0,4.0

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix the behavior of rewrite ScalarFunction IsTure .

@wshwsh12 @ti-srebot
cherry pick pingcap#19621 to release-3.0
14f2372 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 9, 2020
Merged
@ti-srebot ti-srebot added this to the 3.0.19 milestone Sep 9, 2020
qw4990
qw4990 reviewed Sep 11, 2020
View reviewed changes
expression/builtin.go Outdated Show resolved Hide resolved
@wshwsh12
Copy link
Contributor

/run-all-tests

@wshwsh12 wshwsh12 mentioned this pull request Sep 14, 2020
Merged
@wshwsh12
Copy link
Contributor

/run-all-tests

XuHuaiyu
XuHuaiyu previously approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
@XuHuaiyu
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

SunRunAway
SunRunAway previously approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2020
@SunRunAway SunRunAway closed this Sep 17, 2020
@SunRunAway SunRunAway reopened this Sep 17, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@wshwsh12 wshwsh12 dismissed stale reviews from SunRunAway and XuHuaiyu via a36fae3 September 17, 2020 09:47
@bb7133
Copy link
Member

bb7133 commented Sep 17, 2020

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Sep 17, 2020

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Sep 17, 2020

/run-unit-test
/run-check_dev_2

@bb7133
Copy link
Member

bb7133 commented Sep 17, 2020

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@bb7133,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIGs: execution(slack),planner(slack).

@bb7133 bb7133 merged commit e6f07c5 into pingcap:release-3.0 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@bb7133 bb7133 bb7133 approved these changes

@SunRunAway SunRunAway SunRunAway left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@winoros winoros Awaiting requested review from winoros

Assignees

@wshwsh12 wshwsh12

Labels
component/expression sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.19
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @wshwsh12 @XuHuaiyu @SunRunAway @bb7133 @qw4990 @wjhuang2016