expression: fix unmatched column lengths errors caused by builtinGreatestStringSig and builtinLeastStringSig
#19754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
type/bugfix
ti-srebot
approved these changes
Sep 3, 2020
|
/run-all-tests |
|
/run-unit-test |
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Sep 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19758 |
zz-jason
pushed a commit
that referenced
this pull request
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #16147
Problem Summary: expression: fix unmatched column lengths errors caused by
builtinGreatestStringSigandbuiltinLeastStringSigWhat is changed and how it works?
Built-in functions
builtinGreatestStringSigandbuiltinLeastStringSigallocate buffers from their own buffer pool, but they don't initialize allocated buffers before using them, which may cause some problems.Check List
Tests
Release note
builtinGreatestStringSigandbuiltinLeastStringSig