Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: privilege check for SELECT INTO OUTFILE #19553

Merged
merged 2 commits into from Aug 28, 2020
Merged

planner: privilege check for SELECT INTO OUTFILE #19553

merged 2 commits into from Aug 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 27, 2020

What problem does this PR solve?

Problem Summary:

SELECT INTO OUTFILE should require the file privilege. This PR modifies it to use a MySQL compatible error when the privilege check fails.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Breaking backward compatibility (for broken apps)

Release note

  • SELECT INTO OUTFILE now requires the FILE privilege.

@ghost ghost self-requested a review as a code owner August 27, 2020 17:39
@ghost ghost requested review from SunRunAway and removed request for a team August 27, 2020 17:39
lzmhhh123
lzmhhh123 reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2020
winoros
winoros reviewed Aug 28, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 28, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 28, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19474
  • 19462

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@nullnotnil merge failed.

@lzmhhh123 lzmhhh123 merged commit baf0991 into pingcap:master Aug 28, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 28, 2020
@ti-srebot
cherry pick pingcap#19553 to release-4.0
ed65865 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 28, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19577

@ghost ghost deleted the into-outfile-security branch August 28, 2020 14:08
ti-srebot added a commit that referenced this pull request Sep 1, 2020
@ti-srebot
planner: privilege check for SELECT INTO OUTFILE (#19553) (#19577)
502cd8d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ghost ghost mentioned this pull request Sep 14, 2020
Open
@morgo morgo mentioned this pull request Jan 22, 2021
Closed
@morgo morgo mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/privilege sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzmhhh123 @ti-srebot @winoros