planner: make single partition table support index join on inner side #19151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/bugfix
lzmhhh123
requested review from
SunRunAway,
tiancaiamao and
winoros
and removed request for
a team
lzmhhh123
added
the
priority/release-blocker
|
/run-check_dev |
Codecov Report
@@ Coverage Diff @@
## master #19151 +/- ##
===========================================
Coverage 79.1708% 79.1708%
===========================================
Files 550 550
Lines 149992 149992
===========================================
Hits 118750 118750
Misses 21708 21708
Partials 9534 9534 |
tiancaiamao
reviewed
Aug 13, 2020
| func (s *testSuiteWithData) TestIndexJoinOnSinglePartitionTable(c *C) { | ||
| // For issue 19145 | ||
| tk := testkit.NewTestKitWithInit(c, s.store) | ||
| tk.MustExec("set @try_old_partition_implementation = 1") |
There was a problem hiding this comment.
This only fix the old implementation, it's enough for the 4.0 branch (This is a release blocker).
I'll file another PR to fix for the new implementation.
|
LGTM |
|
@tiancaiamao,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: planner(slack). |
winoros
approved these changes
Aug 14, 2020
ti-srebot
approved these changes
Aug 14, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19145
What is changed and how it works?
What's Changed: append partition info for table scan on inner side of index join.
Related changes
Check List
Tests
Side effects
Release note