Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: Add some limit for auto_random (#17119) #18538

Merged
merged 2 commits into from
Jul 14, 2020
Merged

ddl: Add some limit for auto_random (#17119) #18538

merged 2 commits into from
Jul 14, 2020

Conversation

tangenta
Copy link
Contributor

Cherry-pick #17119 to release-4.0.

Release note

  • Limits on auto_random column: the column type can only be bigint, and the max number of auto_random bits is restricted to 15.

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Jul 14, 2020
@tangenta tangenta requested a review from AilinKid July 14, 2020 06:17
tangenta
tangenta commented Jul 14, 2020
View reviewed changes
Copy link
Contributor Author

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@tangenta Oops. LGTM is restricted to reviewers.

AilinKid
AilinKid reviewed Jul 14, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2020
@bb7133
Copy link
Member

bb7133 commented Jul 14, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@tangenta merge failed.

@tangenta
Copy link
Contributor Author

/run-check_dev

----------------------------------------------------------------------
FAIL: sort_test.go:26: testSuite.TestSortInDisk

sort_test.go:60:
    c.Assert(tk.Se.GetSessionVars().StmtCtx.DiskTracker.MaxConsumed(), Greater, int64(0))
... compare_one int64 = 0
... compare_two int64 = 0

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 14, 2020
@bb7133 bb7133 merged commit b407487 into pingcap:release-4.0 Jul 14, 2020
@bb7133 bb7133 mentioned this pull request Jul 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 bb7133 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangenta @ti-srebot @bb7133 @AilinKid @Deardrops