server: return the actual error when conn panic (#18494) #18500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/server
type/4.0-cherry-pick
type/bugfix
|
/run-integration-copr-test |
|
@SunRunAway,Thanks for your review. |
|
LGTM |
|
@lysu,Thanks for your review. |
lysu
approved these changes
Jul 13, 2020
|
/merge |
|
Sorry @XuHuaiyu, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18494 to release-4.0
What problem does this PR solve?
Issue Number: close #18112
Problem Summary:
TiDB does not return the actual error when recovering a goroutine.
What is changed and how it works?
What's Changed:
How it Works:
As the title says.
Related changes
Check List
Tests
As the description in the related issue.
We'll get
ERROR 1105 (HY000): Out Of Memory Quota![conn_id=1]after this commit.Side effects
N/A
Release note