Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: only reserve the sign bit when auto_random column is signed (#15566) #18404

Merged
merged 3 commits into from
Jul 10, 2020
Merged

executor: only reserve the sign bit when auto_random column is signed (#15566) #18404

merged 3 commits into from
Jul 10, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 7, 2020 •
edited
Loading

Cherry-pick #15566 to release-4.0.

Release note

  • The sign bit of auto_random column is reserved to prevent sharding only when the column type is signed.

@sre-bot
Copy link
Contributor

sre-bot commented Jul 7, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@tangenta
Copy link
Contributor Author

tangenta commented Jul 7, 2020

/rebuild

@tangenta
Copy link
Contributor Author

tangenta commented Jul 7, 2020

/run-all-tests

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Jul 7, 2020
@tangenta
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor

@bb7133,Thanks for your review.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@bb7133
Copy link
Member

bb7133 commented Jul 10, 2020

LGTM

wjhuang2016
wjhuang2016 reviewed Jul 10, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

@wjhuang2016,Thanks for your review.

@bb7133 bb7133 merged commit 138590b into pingcap:release-4.0 Jul 10, 2020
@bb7133 bb7133 mentioned this pull request Jul 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@bb7133 bb7133 bb7133 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangenta @sre-bot @ti-srebot @bb7133 @wjhuang2016