Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: drop stats should delete topn #18160

Merged
merged 6 commits into from
Aug 26, 2020
Merged

statistics: drop stats should delete topn #18160

merged 6 commits into from
Aug 26, 2020

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Jun 22, 2020 •
edited
Loading

What problem does this PR solve?

close: #18161

Problem Summary: As the title says.

What is changed and how it works?

What's Changed: delete topn from kv when drop stats.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • drop stats should delete topn.

@lzmhhh123 lzmhhh123 requested a review from a team as a code owner June 22, 2020 04:16
@lzmhhh123 lzmhhh123 requested review from SunRunAway and removed request for a team June 22, 2020 04:16
@zz-jason
Copy link
Member

@lzmhhh123 please:

  • create an issue for this PR
  • add some test for this PR

@codecov
Copy link

codecov bot commented Jun 22, 2020 •
edited
Loading

Codecov Report

Merging #18160 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18160   +/-   ##
===========================================
  Coverage   79.6038%   79.6038%           
===========================================
  Files           526        526           
  Lines        144336     144336           
===========================================
  Hits         114897     114897           
  Misses        20237      20237           
  Partials       9202       9202

@lzmhhh123 lzmhhh123 requested a review from a team as a code owner June 22, 2020 05:09
@github-actions github-actions bot added the sig/execution SIG execution label Jun 22, 2020
@lzmhhh123
Copy link
Contributor Author

/run-unit-test

@lzmhhh123 lzmhhh123 closed this Jun 23, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/drop_stats_contain_top_n branch June 23, 2020 08:19
@lzmhhh123 lzmhhh123 restored the bug-fix/drop_stats_contain_top_n branch June 23, 2020 08:19
@lzmhhh123 lzmhhh123 reopened this Jun 24, 2020
winoros
winoros reviewed Jul 2, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot
Copy link
Contributor

@winoros, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

@lzmhhh123 lzmhhh123 removed the sig/execution SIG execution label Jul 2, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Jul 2, 2020
@zz-jason zz-jason removed the request for review from a team July 7, 2020 05:21
zz-jason
zz-jason approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
@zz-jason zz-jason requested a review from winoros August 26, 2020 01:51
@zz-jason
Copy link
Member

/build_release

@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

@zz-jason Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

SunRunAway
SunRunAway reviewed Aug 26, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 26, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 8fe2a0b into pingcap:master Aug 26, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 26, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#18160 to release-3.0
484f571 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #19464

@lzmhhh123 lzmhhh123 deleted the bug-fix/drop_stats_contain_top_n branch August 26, 2020 06:17
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 26, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#18160 to release-4.0
8be4dd4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19465

ti-srebot added a commit that referenced this pull request Sep 1, 2020
@ti-srebot
statistics: drop stats should delete topn (#18160) (#19465)
c78d6c8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
zz-jason pushed a commit that referenced this pull request Sep 7, 2020
@ti-srebot
statistics: drop stats should delete topn (#18160) (#19464)
3dfed22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@zz-jason zz-jason zz-jason approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/executor component/statistics sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop stats remain the "topn" info in mysql.stats_top_n
6 participants
@lzmhhh123 @zz-jason @ti-srebot @SunRunAway @winoros @AndreMouche