table/tables: fix load partition when upgrade from an old TiDB #17971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @crazycs520 @jackysp |
Codecov Report
@@ Coverage Diff @@
## master #17971 +/- ##
================================================
+ Coverage 79.4729% 79.6788% +0.2059%
================================================
Files 524 524
Lines 142110 142802 +692
================================================
+ Hits 112939 113783 +844
+ Misses 20043 19919 -124
+ Partials 9128 9100 -28 |
imtbkcat
reviewed
Jun 12, 2020
| if err != nil { | ||
| return 0, false | ||
| } | ||
| ret, isNull, err := tmp.EvalInt(sctx, chunk.Row{}) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-common-test |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 12, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17983 |
tiancaiamao
added a commit
that referenced
this pull request
Jun 15, 2020
#17983 Signed-off-by: sre-bot <sre-bot@pingcap.com> Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17952
Problem Summary:
In the old version TiDB, partition definition store the less than XXX as raw expression.
It should be integer, the new version TiDB assert XXX is an integer.
What is changed and how it works?
What's Changed:
Add some code to handle compatibility.
How it Works:
If the less than expression is not an integer, try to parser it as expression and calculate the integer.
Related changes
Check List
Tests
I have manually test the binary with issue #17952 and it works.
Side effects
Ugly code
Release note