Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix a bug that the coercibility of user variable is wrong (#17676) #17890

Merged
merged 3 commits into from
Jun 11, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 10, 2020

cherry-pick #17676 to release-4.0


Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #17675

Problem Summary:
We didn't handle the coercibility for user variables.

What is changed and how it works?

Set the coercibility of user variables to CoercibilityImplicit.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • fix a bug that the coercibility of user variable is wrong

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 10, 2020

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Jun 11, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 11, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 11, 2020

@sre-bot merge failed.

@bb7133
Copy link
Member

bb7133 commented Jun 11, 2020

/run-integration-copr-test

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 9920cb1 into pingcap:release-4.0 Jun 11, 2020
@iosmanthus
Copy link
Contributor

/run-integration-copr-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants