Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix error message of access denied (#17449) #17724

Merged
merged 3 commits into from
Jun 11, 2020
Merged

*: fix error message of access denied (#17449) #17724

merged 3 commits into from
Jun 11, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 5, 2020

cherry-pick #17449 to release-4.0

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

fix error message when privilege is not enough to access table or database.

MySQL [(none)]> select * from test.t;
ERROR 1142 (42000): SELECT command denied to user 'u1'@'127.0.0.1' for table 't'
MySQL [(none)]> create table test.t (x int);
ERROR 1142 (42000): CREATE command denied to user '127.0.0.1'@'u1' for table 't'
MySQL [(none)]> create table test.t (x int);

What's Changed:

Some of error message were produced in an incorrect way, which reverse AuthHostname and AuthUsername. Some of them use Hostname rather than AuthHostname.

How it Works:

fix them all.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • None

Release note

  • fix error message when access denied.

@sre-bot
cherry pick pingcap#17449 to release-4.0
f100f5c 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jun 5, 2020
Merged
@sre-bot sre-bot added this to the v4.0.1 milestone Jun 5, 2020
@bb7133 bb7133 modified the milestones: v4.0.1, v4.0.2 Jun 6, 2020
@imtbkcat
Copy link

imtbkcat commented Jun 8, 2020

/run-all-tests tidb-test=pr/1065

1 similar comment
@imtbkcat
Copy link

imtbkcat commented Jun 8, 2020

/run-all-tests tidb-test=pr/1065

jackysp
jackysp reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lzmhhh123
lzmhhh123 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jun 8, 2020

/merge

1 similar comment
@jackysp
Copy link
Member

jackysp commented Jun 8, 2020

/merge

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2020
@imtbkcat
Copy link

imtbkcat commented Jun 9, 2020

/run-all-tests

@jackysp jackysp removed the sig/sql-infra SIG: SQL Infra label Jun 9, 2020
@jackysp
Copy link
Member

jackysp commented Jun 9, 2020

/merge

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 9, 2020
@imtbkcat
Copy link

/run-all-tests

@imtbkcat
Copy link

/run-integration-common-test

@zhouqiang-cl
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 10, 2020

Sorry @zhouqiang-cl, you don't have permission to trigger auto merge event on this branch.

@zhouqiang-cl
Copy link
Contributor

/run-integration-common-test

1 similar comment
@glorv
Copy link
Contributor

glorv commented Jun 10, 2020

/run-integration-common-test

@tiancaiamao
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 10, 2020

Sorry @zhouqiang-cl, you don't have permission to trigger auto merge event on this branch.

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Jun 10, 2020

/run-integration-common-test

1 similar comment
@imtbkcat
Copy link

/run-integration-common-test

@imtbkcat
Copy link

/run-integration-common-test tidb-test=pr/1063

@glorv
Copy link
Contributor

glorv commented Jun 10, 2020

/run-integration-common-test

@bb7133
Copy link
Member

bb7133 commented Jun 10, 2020

/run-integration-common-test tidb-test=pr/1063

@imtbkcat
Copy link

/run-integration-common-test tidb-test

@imtbkcat
Copy link

/run-all-tests

1 similar comment
@imtbkcat
Copy link

/run-all-tests

@imtbkcat
Copy link

/run-integration-common-test

3 similar comments
@imtbkcat
Copy link

/run-integration-common-test

@glorv
Copy link
Contributor

glorv commented Jun 11, 2020

/run-integration-common-test

@imtbkcat
Copy link

/run-integration-common-test

@jackysp jackysp merged commit 5f59b40 into pingcap:release-4.0 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

Assignees

@imtbkcat imtbkcat

Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/usability type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging this pull request may close these issues.
8 participants
@sre-bot @imtbkcat @jackysp @zhouqiang-cl @glorv @tiancaiamao @bb7133 @lzmhhh123