Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix error message of access denied (#17449) #17722

Merged
merged 4 commits into from
Jun 11, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 5, 2020

cherry-pick #17449 to release-3.0


What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

fix error message when privilege is not enough to access table or database.

MySQL [(none)]> select * from test.t;
ERROR 1142 (42000): SELECT command denied to user 'u1'@'127.0.0.1' for table 't'
MySQL [(none)]> create table test.t (x int);
ERROR 1142 (42000): CREATE command denied to user '127.0.0.1'@'u1' for table 't'
MySQL [(none)]> create table test.t (x int);

What's Changed:

Some of error message were produced in an incorrect way, which reverse AuthHostname and AuthUsername. Some of them use Hostname rather than AuthHostname.

How it Works:

fix them all.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • None

Release note

  • fix error message when access denied.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 5, 2020

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM, please update tidb-test

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 9, 2020
@AndreMouche
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 11, 2020

Sorry @AndreMouche, you don't have permission to trigger auto merge event on this branch.

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp removed the sig/sql-infra SIG: SQL Infra label Jun 11, 2020
@jackysp
Copy link
Member

jackysp commented Jun 11, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit 70e4ef1 into pingcap:release-3.0 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/usability type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants