Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: reject alter auto_random_base on a non auto_random table #17714

Merged
merged 6 commits into from
Jun 6, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 5, 2020

What problem does this PR solve?

Issue Number: close #17713

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

  • Add a check on t.Meta().AutoRandomBits
  • Add a tiny test

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

Release note

  • Disallow alter auto_random_base on a non-auto_random table.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Jun 5, 2020
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta
Copy link
Contributor Author

tangenta commented Jun 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

Your auto merge job has been accepted, waiting for:

  • 17622
  • 17706
  • 17556

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #17714 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17714   +/-   ##
===========================================
  Coverage   79.5935%   79.5935%           
===========================================
  Files           524        524           
  Lines        141999     141999           
===========================================
  Hits         113022     113022           
  Misses        19916      19916           
  Partials       9061       9061           

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

@tangenta merge failed.

@AilinKid
Copy link
Contributor

AilinKid commented Jun 5, 2020

/run-integration-br-test

@AilinKid
Copy link
Contributor

AilinKid commented Jun 5, 2020

/run-all-tests

@tangenta
Copy link
Contributor Author

tangenta commented Jun 5, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

@tangenta merge failed.

@tangenta
Copy link
Contributor Author

tangenta commented Jun 6, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit a4eb75a into pingcap:master Jun 6, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 6, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 6, 2020

cherry pick to release-3.1 in PR #17827

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 6, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 6, 2020

cherry pick to release-4.0 in PR #17828

ti-srebot added a commit that referenced this pull request Jun 29, 2020
#17827)

* cherry pick #17714 to release-3.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflicts

Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: Arenatlx <ailinsilence4@gmail.com>
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modification on auto_random_base of a non auto_random table should be rejected
5 participants