infoschema: fix select * from inspection_summary would return null. (#16099)

[crazycs520]

cherry-pick #16254 #16099

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

1. Currently it would return empty results without rule condition.

What is changed and how it works?

1. Make it return all the results for select * from inspection.
2. Add a column name COMMENT to explain the row.

What's Changed:
before:

mysql> select * from inspection_summary;
Empty set (0.00 sec)

this pr :

mysql> select * from inspection_summary limit 10;
+-------+------------------+------------------------------------------+----------------+----------+-----------+-----------+-----------+------------------------------------------------------------------------------------------------------+
| RULE  | INSTANCE         | METRICS_NAME                             | LABEL          | QUANTILE | AVG_VALUE | MIN_VALUE | MAX_VALUE | COMMENT                                                                                              |
+-------+------------------+------------------------------------------+----------------+----------+-----------+-----------+-----------+------------------------------------------------------------------------------------------------------+
| stats | gncluster-tidb-0 | tidb_statistics_auto_analyze_duration    |                |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB auto analyze time durations within 95 percent histogram buckets                 |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | access_regions |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | region_error   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | sample         |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | scan_keys      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats | gncluster-tidb-0 | tidb_statistics_fast_analyze_status      | seek_keys      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB fast analyze statistics                                                         |
| stats |                  | tidb_statistics_pseudo_estimation_ops    |                |     NULL |  0.000000 |  0.000000 |  0.000000 | TiDB optimizer using pseudo estimation counts                                                        |
| stats |                  | tidb_statistics_significant_feedback     |                |     NULL |  0.000000 |  0.000000 |  0.000000 | Counter of query feedback whose actual count is much different than calculated by current statistics |
| stats | gncluster-tidb-0 | tidb_statistics_stats_inaccuracy_rate    |                |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB statistics inaccurate rate                                                      |
| stats | gncluster-tidb-0 | tidb_statistics_store_query_feedback_qps | ok             |     NULL |  0.044445 |  0.044443 |  0.044445 | TiDB store quering feedback counts                                                                   |
+-------+------------------+------------------------------------------+----------------+----------+-----------+-----------+-----------+------------------------------------------------------------------------------------------------------+
10 rows in set (21.26 sec)

mysql> select * from inspection_summary where rule='query-summary' and metrics_name='tidb_query_duration';
+---------------+------------------+---------------------+----------+----------+-----------+-----------+-----------+----------------------------------------------+
| RULE          | INSTANCE         | METRICS_NAME        | LABEL    | QUANTILE | AVG_VALUE | MIN_VALUE | MAX_VALUE | COMMENT                                      |
+---------------+------------------+---------------------+----------+----------+-----------+-----------+-----------+----------------------------------------------+
| query-summary | gncluster-tidb-0 | tidb_query_duration | Begin    |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Commit   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Delete   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Execute  |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Insert   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Replace  |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Rollback |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Select   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Set      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Show     |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Update   |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | Use      |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | general  |     0.99 |  0.000000 |  0.000000 |  0.000000 | The quantile of TiDB query durations(second) |
| query-summary | gncluster-tidb-0 | tidb_query_duration | internal |     0.99 |  0.004050 |  0.003934 |  0.005480 | The quantile of TiDB query durations(second) |
+---------------+------------------+---------------------+----------+----------+-----------+-----------+-----------+----------------------------------------------+
14 rows in set (0.09 sec)

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

• Unit test
• Integration test

Release note

• fix query inspection_summary without condition would return null.

[sre-bot]

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

[crazycs520]

/rebuild

[sre-bot]

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

[crazycs520]

/run-all-tests

[crazycs520]

/rebulid

[lonng]

LGTM

[AilinKid]

LGTM

[AilinKid]

/run-all-tests

[crazycs520]

/run-all-tests

[crazycs520]

/run-unit-test

[crazycs520]

/run-integration-ddl-test