Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix pre-split region timeout constraint not work when create table (#17459) #17619

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 3, 2020

cherry-pick #17459 to release-4.0


What problem does this PR solve?

close #17458

As the title said.

What is changed and how it works?

Use context.WithTimeout.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test

Side effects

  • No

Release note

  • Fix pre-split region timeout constraint not work when create table.

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 3, 2020

/run-all-tests

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 removed their request for review June 4, 2020 06:58
@crazycs520
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 5, 2020
@crazycs520
Copy link
Contributor

/run-common-test

@zimulala zimulala merged commit 80da4d6 into pingcap:release-4.0 Jun 5, 2020
@bb7133 bb7133 modified the milestones: v4.0.1, v4.0.2 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants