expression: push down expr json_length to tiflash #17588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/run-all-tests |
|
/rebuild |
Signed-off-by: Tong Zhigao <tongzhigao@pingcap.com>
|
@lzmhhh123 PTAL |
Codecov Report
@@ Coverage Diff @@
## master #17588 +/- ##
================================================
- Coverage 79.5052% 79.4216% -0.0837%
================================================
Files 520 520
Lines 140041 139904 -137
================================================
- Hits 111340 111114 -226
- Misses 19740 19821 +81
- Partials 8961 8969 +8 |
wshwsh12
added
status/LGT2
|
/run-all-tests |
|
cherry pick to release-4.0 failed |
|
/unlabel component/expression |
|
/label component/expression |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17592 |
sre-bot
added a commit
that referenced
this pull request
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tong Zhigao tongzhigao@pingcap.com
What problem does this PR solve?
tiflash has implemented expression
json_lengthin PR: [FLASH-1141] support json_length expr tiflash#741.Make tidb can push down scalar function
json_lengthto tiflash.What is changed and how it works?
What's Changed:
json_lengthto white list which can be pushed down to tiflash.Check List
Tests
Release note