ddl, variable: add system variable to control Clustered Index feature #17561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17561 +/- ##
===========================================
Coverage 79.6443% 79.6443%
===========================================
Files 520 520
Lines 140806 140806
===========================================
Hits 112144 112144
Misses 19726 19726
Partials 8936 8936 |
wjhuang2016
reviewed
Jun 1, 2020
| @@ -1112,3 +1112,39 @@ func (s *testSerialSuite) TestInvisibleIndex(c *C) { | |||
| tk.MustQuery("select * from t6").Check(testkit.Rows("1 2")) | |||
| tk.MustGetErrCode("alter table t6 drop primary key", errno.ErrPKIndexCantBeInvisible) | |||
| } | |||
|
|
|||
| func (s *testSerialSuite) TestCreateClusteredIndex(c *C) { | |||
There was a problem hiding this comment.
Please add some tests for CreateTableLike
ddl/ddl_api.go
Outdated
| @@ -1505,7 +1505,14 @@ func buildTableInfoWithStmt(ctx sessionctx.Context, s *ast.CreateTableStmt, dbCh | |||
| if err = handleTableOptions(s.Options, tbInfo); err != nil { | |||
| return nil, errors.Trace(err) | |||
| } | |||
|
|
|||
| if ctx.GetSessionVars().EnableClusteredIndex && !tbInfo.PKIsHandle && !config.GetGlobalConfig().AlterPrimaryKey { | |||
There was a problem hiding this comment.
I think it's better to move to about L1267 if constr.Tp == ast.ConstraintPrimaryKey and deal with the invisible index checking.
|
/run-all-tests |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support the clustered index feature.
What is changed and how it works?
Add a global variable to control the clustered index feature.
Check List
Tests
Side effects
Release note