Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, executor: support insert/replace into partition (#17280) #17313

Merged
merged 6 commits into from
May 21, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 20, 2020

cherry-pick #17280 to release-4.0


What problem does this PR solve?

Before this commit:

tidb> insert into t1 partition (p0,p1) values(2, 'a');
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 24 near "partition (p0,p1) values(2, 'a')"

After this commit:

tidb> insert into t1 partition (p0,p1) values(2, 'a');
Query OK, 1 row affected (0.00 sec)

tidb> select * from t1 partition(p0);
+------+------+
| a    | b    |
+------+------+
|    2 | a    |
+------+------+
1 row in set (0.00 sec)

Problem Summary:

What is changed and how it works?

Check the given partition set when executing insert/replace.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • Support insert/replace into tbl_name partition(partition_name_list)

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested review from a team as code owners May 20, 2020 08:52
@sre-bot
Copy link
Contributor Author

sre-bot commented May 20, 2020

/run-all-tests

@ghost ghost requested review from XuHuaiyu and winoros and removed request for a team May 20, 2020 08:52
@sre-bot sre-bot added sig/execution SIG execution sig/planner SIG: Planner priority/release-blocker This issue blocks a release. Please solve it ASAP. type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 20, 2020
@sre-bot sre-bot added this to the v4.0.0-ga milestone May 20, 2020
@XuHuaiyu
Copy link
Contributor

wait for #17305

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label May 21, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jebter
Copy link

jebter commented May 21, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 21, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

/run-all-tests

@sre-bot sre-bot merged commit 70e94b4 into pingcap:release-4.0 May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants