executor: fix the issue that UNIQUE constraint on boolean column results in an incorrect result in a comparison #17245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qw4990
added
type/bugfix
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #17245 +/- ##
===========================================
Coverage 80.1075% 80.1075%
===========================================
Files 511 511
Lines 139832 139832
===========================================
Hits 112016 112016
Misses 18864 18864
Partials 8952 8952 |
|
/rebuild |
qw4990
added
status/can-merge
|
/merge |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 20, 2020
…lts in an incorrect result in a comparison (pingcap#17245)
|
cherry pick to release-4.0 in PR #17306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close tidb-challenge-program/bug-hunting-issue#49
Problem Summary: fix the issue that UNIQUE constraint on
booleancolumn results in an incorrect result in comparison.What is changed and how it works?
The root cause is that if there is an index on the column
c1, TiDB will generate apoint-getplan for the querySELECT t0.c1 FROM t0 WHERE t0.c1=-129.When encoding the index key from the value
-129, an overflow error occurs since the range ofBOOLvalues is[-128, 127], but TiDB ignore this error and convert it to-128, and then we get an incorrect result.Check List
Tests
Release note