expression: NotNullFlag is not set correctly for some expression #16954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
windtalker
changed the title
XuHuaiyu
reviewed
Apr 30, 2020
types/field_type.go
Outdated
| // currently only NotNullFlag is checked | ||
| // todo more flag need to be checked, for example: UnsignedFlag | ||
| func mergeTypeFlag(a, b uint) uint { | ||
| ret := a |
There was a problem hiding this comment.
return a & (b & mysql.NotNullFlag | ^mysql.NotNullFlag) is ok ?
Codecov Report
@@ Coverage Diff @@
## master #16954 +/- ##
===========================================
Coverage 80.0393% 80.0393%
===========================================
Files 509 509
Lines 138868 138868
===========================================
Hits 111149 111149
Misses 18773 18773
Partials 8946 8946 |
|
/rebuild |
|
/rebuild |
1 similar comment
|
/rebuild |
qw4990
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-2.1 in PR #16992 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 6, 2020
|
cherry pick to release-3.0 in PR #16993 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 6, 2020
|
cherry pick to release-3.1 in PR #16994 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 6, 2020
|
cherry pick to release-4.0 in PR #16995 |
zz-jason
pushed a commit
that referenced
this pull request
May 7, 2020
sre-bot
added a commit
that referenced
this pull request
May 7, 2020
sre-bot
added a commit
that referenced
this pull request
May 7, 2020
sre-bot
added a commit
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
for some expression, the result type's NotNullFlag is not set correctly
What is changed and how it works?
Check and adjust type flag in
AggFieldTypeRelated changes
Check List
Tests
Side effects
Release note
case whenexpression