Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: make query on partition table not cacheable (#16375) #16759

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 23, 2020

cherry-pick #16375 to release-3.0


What problem does this PR solve?

Issue Number: close #16364

Problem Summary:
#15697 will check whether plan is a query on partition table and will pass by if is true. But there is still some problems bring by stmtCtx.UseCache. If a plan is Cacheable, stmtCtx.UseCache is set to true. So the simpleRewriter has different output compare with not cached plan.

For example, in #16364. If prepare-plan-cache is on, although query on partition table is not cached, it has different plan.

not use cache:
lt(test.employees.id, 3)
use cache:
lt(cast(test.employees.id), 3)

this small change in rewriter cause partition pruning fail.

What is changed and how it works?

Proposal: xxx

What's Changed:
add partition check in Cacheable function rather than getPhysicalPlan

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 23, 2020

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Apr 29, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 29, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 29, 2020

@sre-bot merge failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants