config: remove allow-auto-random config option #16596

tangenta · 2020-04-20T04:59:19Z

What problem does this PR solve?

Problem Summary: Since the attribute auto_random is stable now, we can move the option allow-auto-random out of the [experimental] section in configuration file.

What is changed and how it works?

What's Changed:

How it Works:

Related changes

PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

Unit test
Integration test

Side effects

Release note

The column attribute auto_random gets stable and it can be used without the config option allow-auto-random.

codecov · 2020-04-20T05:06:21Z

Codecov Report

Merging #16596 into master will increase coverage by 0.3738%.
The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master     #16596        +/-   ##
================================================
+ Coverage   80.0128%   80.3866%   +0.3738%     
================================================
  Files           510        506         -4     
  Lines        138984     136718      -2266     
================================================
- Hits         111205     109903      -1302     
+ Misses        18817      18231       -586     
+ Partials       8962       8584       -378

AilinKid

LGTM

config/config.toml.example

ddl/serial_test.go

sre-bot · 2020-05-11T07:39:26Z

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

AilinKid

Rest LGTM

meta/autoid/errors.go

util/testutil/testutil.go

zimulala

LGTM

crazycs520

LGTM

…imental

sre-bot · 2020-06-10T05:27:29Z

/run-all-tests

sre-bot · 2020-06-10T05:30:02Z

@tangenta merge failed.

tangenta · 2020-06-10T05:32:09Z

/common-test

[2020-06-10T05:29:46.910Z] ./t/drop.test: ok! 19 test cases passed, take time 0.253035931 s

[2020-06-10T05:29:47.166Z] time="2020-06-10T13:29:46+08:00" level=info msg="run test [drop] ok"

[2020-06-10T05:29:47.166Z] time="2020-06-10T13:29:46+08:00" level=warning msg="Create new db&{0 {root:@tcp(127.0.0.1:4001)/test?strict=true&time_zone=%27Asia%2FShanghai%27 0x10a1110} 0 {0 0} [0xc0006e8900] map[] 0 1 0xc0006cea80 0xc0005f1e00 false map[0xc0006e8900:map[0xc0006e8900:true]] map[] 0 0 0 <nil> 0 0 0 0x48c430}"

[2020-06-10T05:29:47.166Z] time="2020-06-10T13:29:46+08:00" level=fatal msg="run test [insert_select] err: sql:INSERT INTO t1 VALUES (1,1),(2,2),(10,10);: run \"INSERT INTO t1 VALUES (1,1),(2,2),(10,10);\" at line 134 err Error 1146: Table 'test.t1' doesn't exist"

tangenta · 2020-06-10T05:33:04Z

/merge

sre-bot · 2020-06-10T05:33:29Z

/run-all-tests

sre-bot · 2020-06-10T05:36:30Z

@tangenta merge failed.

tangenta · 2020-06-10T05:40:27Z

/run-unit-test
Data race:

[2020-06-10T05:34:50.397Z] WARNING: DATA RACE

[2020-06-10T05:34:50.397Z] Write at 0x00c000171158 by goroutine 255:

[2020-06-10T05:34:50.397Z]   github.com/pingcap/tidb/session_test.(*testSessionSerialSuite).TestStatementCountLimit()

[2020-06-10T05:34:50.397Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session_test.go:2456 +0x1c9

[2020-06-10T05:34:50.397Z]   github.com/pingcap/tidb/session_test.(*testSessionSerialSuite).TestStatementCountLimit()

[2020-06-10T05:34:50.397Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session_test.go:2454 +0x12d

[2020-06-10T05:34:50.397Z]   runtime.call32()

[2020-06-10T05:34:50.397Z]       /usr/local/go/src/runtime/asm_amd64.s:539 +0x3a

[2020-06-10T05:34:50.397Z]   reflect.Value.Call()

[2020-06-10T05:34:50.397Z]       /usr/local/go/src/reflect/value.go:321 +0xd3

[2020-06-10T05:34:50.397Z]   github.com/pingcap/check.(*suiteRunner).forkTest.func1()

[2020-06-10T05:34:50.397Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:850 +0x9aa

[2020-06-10T05:34:50.397Z]   github.com/pingcap/check.(*suiteRunner).forkCall.func1()

[2020-06-10T05:34:50.397Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/pkg/mod/github.com/pingcap/check@v0.0.0-20200212061837-5e12011dc712/check.go:739 +0x113

[2020-06-10T05:34:50.397Z] 

[2020-06-10T05:34:50.397Z] Previous read at 0x00c000171158 by goroutine 568:

[2020-06-10T05:34:50.397Z]   github.com/pingcap/tidb/session.checkStmtLimit()

[2020-06-10T05:34:50.397Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/tidb.go:247 +0xe7

[2020-06-10T05:34:50.397Z]   github.com/pingcap/tidb/session.finishStmt()

[2020-06-10T05:34:50.397Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/tidb.go:211 +0x133

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/session.runStmtWrap()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1224 +0x568

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/session.(*session).ExecuteStmt()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1164 +0xa6f

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/session.(*session).Execute()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/session/session.go:1077 +0x3ee

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/ddl/util.RemoveFromGCDeleteRange()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/util/util.go:121 +0x18f

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/ddl/util.CompleteDeleteRange()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/util/util.go:115 +0x227

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/ddl.(*delRange).doTask()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/delete_range.go:230 +0x611

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/ddl.(*delRange).doDelRangeWork()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/delete_range.go:184 +0x54c

[2020-06-10T05:34:50.398Z]   github.com/pingcap/tidb/ddl.(*delRange).startEmulator()

[2020-06-10T05:34:50.398Z]       /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/ddl/delete_range.go:148 +0x1db

AilinKid · 2020-06-10T05:54:59Z

/run-unit-test

AilinKid · 2020-06-10T06:03:10Z

/run-integration-br-test

tangenta added the component/config label Apr 20, 2020

tangenta requested a review from a team as a code owner April 20, 2020 04:59

ghost requested review from XuHuaiyu and removed request for a team April 20, 2020 04:59

github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Apr 20, 2020

tangenta requested review from AilinKid and bb7133 April 20, 2020 06:24

AilinKid reviewed Apr 20, 2020

View reviewed changes

bb7133 reviewed Apr 20, 2020

View reviewed changes

config/config.toml.example Outdated Show resolved Hide resolved

tangenta changed the title ~~config: move auto_random out of experimental section~~ config: remove allow-auto-random config option Apr 21, 2020

zimulala reviewed Apr 30, 2020

View reviewed changes

ddl/serial_test.go Outdated Show resolved Hide resolved

tangenta added the status/DNM label May 11, 2020

XuHuaiyu removed their request for review May 12, 2020 14:19

config: remove allow-auto-random config option

2bb1ff5

tangenta force-pushed the autorand-rm-experimental branch from c8085cd to 2bb1ff5 Compare June 10, 2020 01:12

tangenta mentioned this pull request Jun 10, 2020

restore: remove auto_random option pingcap/br#343

Merged

tangenta removed the status/DNM label Jun 10, 2020

AilinKid reviewed Jun 10, 2020

View reviewed changes

meta/autoid/errors.go Show resolved Hide resolved

zimulala reviewed Jun 10, 2020

View reviewed changes

util/testutil/testutil.go Show resolved Hide resolved

tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2020

zimulala reviewed Jun 10, 2020

View reviewed changes

crazycs520 reviewed Jun 10, 2020

View reviewed changes

tangenta added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 10, 2020

tangenta added 2 commits June 10, 2020 13:19

Merge remote-tracking branch 'upstream/master' into autorand-rm-exper…

a091af2

…imental

update br dependency

e4e4f82

zimulala approved these changes Jun 10, 2020

View reviewed changes

zimulala added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Jun 10, 2020

tangenta added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2020

AilinKid approved these changes Jun 10, 2020

View reviewed changes

Merge branch 'master' into autorand-rm-experimental

f2c8357

tangenta merged commit f12cdc4 into pingcap:master Jun 10, 2020

kennytm mentioned this pull request Jun 10, 2020

Determine the dependency update strategy between BR and TiDB pingcap/br#345

Open

3pointer mentioned this pull request Jun 10, 2020

update tidb version to latest pingcap/br#346

Merged

kennytm mentioned this pull request Jun 10, 2020

Move auto_random out of experimental features #17882

Closed

tangenta mentioned this pull request Jul 16, 2020

config: remove allow-auto-random config option (#16596) #18613

Merged

tangenta added a commit to tangenta/tidb that referenced this pull request Jul 16, 2020

config: remove allow-auto-random config option (pingcap#16596)

2bc02be

bb7133 pushed a commit that referenced this pull request Jul 16, 2020

config: remove allow-auto-random config option (#16596) (#18613)

b10faca

amyangfei mentioned this pull request Jul 29, 2020

upgrade tidb module, remove deprecated auto random option pingcap/tidb-tools#378

Merged

tangenta mentioned this pull request Oct 9, 2020

tidb-configuration-file: remove allow-auto-random from config manual pingcap/docs-cn#4642

Merged

9 tasks

ti-srebot mentioned this pull request Oct 10, 2020

tidb-configuration-file: remove allow-auto-random from config manual (#4642) pingcap/docs-cn#4650

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config: remove allow-auto-random config option #16596

config: remove allow-auto-random config option #16596

tangenta commented Apr 20, 2020 •

edited

Loading

codecov bot commented Apr 20, 2020 •

edited

Loading

AilinKid left a comment

sre-bot commented May 11, 2020

AilinKid left a comment

zimulala left a comment

crazycs520 left a comment

sre-bot commented Jun 10, 2020

sre-bot commented Jun 10, 2020

tangenta commented Jun 10, 2020

tangenta commented Jun 10, 2020

sre-bot commented Jun 10, 2020

sre-bot commented Jun 10, 2020

tangenta commented Jun 10, 2020

AilinKid commented Jun 10, 2020

AilinKid commented Jun 10, 2020

config: remove allow-auto-random config option #16596

config: remove allow-auto-random config option #16596

Conversation

tangenta commented Apr 20, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

codecov bot commented Apr 20, 2020 • edited Loading

Codecov Report

AilinKid left a comment

Choose a reason for hiding this comment

sre-bot commented May 11, 2020

AilinKid left a comment

Choose a reason for hiding this comment

zimulala left a comment

Choose a reason for hiding this comment

crazycs520 left a comment

Choose a reason for hiding this comment

sre-bot commented Jun 10, 2020

sre-bot commented Jun 10, 2020

tangenta commented Jun 10, 2020

tangenta commented Jun 10, 2020

sre-bot commented Jun 10, 2020

sre-bot commented Jun 10, 2020

tangenta commented Jun 10, 2020

AilinKid commented Jun 10, 2020

AilinKid commented Jun 10, 2020

tangenta commented Apr 20, 2020 •

edited

Loading

codecov bot commented Apr 20, 2020 •

edited

Loading