Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16558

Merged
merged 5 commits into from
Apr 28, 2020
Merged

expression: fix the issue that incorrect result for a predicate that uses the CHAR() function (#16014) #16558

merged 5 commits into from
Apr 28, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 17, 2020

cherry-pick #16014 to release-3.1

What problem does this PR solve?

Issue Number: close #15986

What is changed and how it works?

When we use the string type to determine the bool value, the string type is converted to a float type instead of an int type.

Check List

Tests

  • Unit test
  • Integration test

@Reminiscent @sre-bot
cherry pick pingcap#16014 to release-3.1
a0fa32e 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 17, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 17, 2020
Merged
@sre-bot sre-bot added this to the v3.1.0-ga milestone Apr 17, 2020
@Reminiscent
Copy link
Contributor

wait for tikv/tikv#7547

@wshwsh12 wshwsh12 mentioned this pull request Apr 26, 2020
Merged
@Reminiscent
Copy link
Contributor

/run-all-tests tikv=pr/7547

1 similar comment
@Reminiscent
Copy link
Contributor

/run-all-tests tikv=pr/7547

@Reminiscent
Copy link
Contributor

@qw4990 @SunRunAway PTAL

qw4990
qw4990 reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 28, 2020
SunRunAway
SunRunAway reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 28, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

Your auto merge job has been accepted, waiting for:

  • 16628

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit a81e7d0 into pingcap:release-3.1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees

@Reminiscent Reminiscent

Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Milestone
v3.1.0-ga
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @Reminiscent @SunRunAway @qw4990 @zz-jason