Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix redundant brackets cause full group by check failed (#14955) #16012

Merged
merged 3 commits into from
Apr 4, 2020
Merged

planner: fix redundant brackets cause full group by check failed (#14955) #16012

merged 3 commits into from
Apr 4, 2020

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Apr 2, 2020

What problem does this PR solve?

fix #14947

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/3.0-cherry-pick labels Apr 2, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Apr 2, 2020
lzmhhh123
lzmhhh123 reviewed Apr 2, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 2, 2020
zz-jason
zz-jason approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 3, 2020

Your auto merge job has been accepted, waiting for 15739, 16015

@sre-bot
Copy link
Contributor

sre-bot commented Apr 3, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 3, 2020

@XuHuaiyu merge failed.

@zz-jason zz-jason merged commit 43c2a35 into pingcap:release-3.0 Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @sre-bot @zz-jason @lzmhhh123