Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix incorrect result of logical operators for vectorized expression evaluation (#15891) #15907

Merged
merged 9 commits into from
Apr 4, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 31, 2020

cherry-pick #15891 to release-4.0


What problem does this PR solve?

Related to: #PR12173 #issue15718

What is changed and how it works?

Apply changes from #PR12173 to vectorized expression evaluation.
Fix the wrong bitwise operations.

Check List

Tests

  • Unit test

@sre-bot sre-bot requested a review from a team as a code owner March 31, 2020 09:44
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 31, 2020

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2020
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

Your auto merge job has been accepted, waiting for 15869

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

@sre-bot merge failed.

@SunRunAway
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

Your auto merge job has been accepted, waiting for 15776, 15889, 15926, 15889, 15861, 15955, 15860, 15868

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 1, 2020

@sre-bot merge failed.

@Reminiscent Reminiscent requested a review from SunRunAway April 2, 2020 02:40
@zz-jason
Copy link
Member

zz-jason commented Apr 3, 2020

/merge

@zz-jason zz-jason removed request for SunRunAway and qw4990 April 4, 2020 04:05
@zz-jason zz-jason merged commit 94895a2 into pingcap:release-4.0 Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants