privilege: use internal session to run SET DEFAULT ROL ALL
#15525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
ghost
requested review from
SunRunAway and
wshwsh12
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15525 +/- ##
===========================================
Coverage 80.4497% 80.4497%
===========================================
Files 503 503
Lines 134648 134648
===========================================
Hits 108324 108324
Misses 17810 17810
Partials 8514 8514 |
|
Is there a test to cover this? |
imtbkcat
added
priority/non-release-blocker
priority/release-blocker
|
|
imtbkcat
force-pushed
the
fixSetDefaultAll
branch
from
a0b0da9
to
d9eb430
Compare
|
@tiancaiamao test has been added. |
|
/run-all-tests |
|
/run-all-tests |
|
LGTM |
tiancaiamao
approved these changes
Mar 23, 2020
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 23, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15585 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 23, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15586 |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Mar 24, 2020
sre-bot
pushed a commit
that referenced
this pull request
Mar 25, 2020
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Mar 31, 2020
sre-bot
pushed a commit
that referenced
this pull request
Mar 31, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
SET DEFAULT ROLE ALLis using context session to run internal SQL. Error will occur if user don't haveSELECTprivilege onmysql.default_rolesWhat is changed and how it works?
using internal session to run
SET DEFAULT ALLRelated changes
Check List
Tests
Side effects
Release note