planner: fix bug some cases index merge join hint doesn't work #15515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
eurekaka and
winoros
and removed request for
a team
|
PTAL @eurekaka |
XuHuaiyu
reviewed
Mar 22, 2020
| break | ||
| } | ||
| } | ||
| // Index merge join has more strict conditions than index join and index hash join, |
There was a problem hiding this comment.
- IndexMergeJoin requires stricter conditions than Index(Hash)Join when the output order is needed.
- IndexMergeJoin requires looser conditions than Index(Hash)Join when the output is unordered.
- If ordered-Index(Hash)Join can be chosen but ordered-IndexMergeJoin can not be chosen, we can build a plan with an enforced sort on IndexMergeJoin.
- Thus we can give up the plans here if IndexMergeJoin is nil when
hasINLMJHintis true. Because we can make sure that an IndexMeregJoin with enforced sort will be built.
Codecov Report
@@ Coverage Diff @@
## master #15515 +/- ##
===========================================
Coverage ? 80.3874%
===========================================
Files ? 502
Lines ? 133970
Branches ? 0
===========================================
Hits ? 107695
Misses ? 17807
Partials ? 8468 |
|
LGTM |
|
PTAL @eurekaka |
lzmhhh123
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 15478 |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
lzmhhh123
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 15507 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15484
Problem Summary: As title says.
What is changed and how it works?
What's Changed: A hack change, you can check the comment in the code change.
Check List
Tests
Side effects