*: use https protocol between tidb-pd tidb-tidb when cluster-ssl configured #15342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
/run-all-tests |
lysu
changed the title
github-actions
bot
added
sig/sql-infra
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #15342 +/- ##
================================================
- Coverage 80.4736% 80.3598% -0.1139%
================================================
Files 502 502
Lines 133676 133242 -434
================================================
- Hits 107574 107073 -501
- Misses 17685 17753 +68
+ Partials 8417 8416 -1 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
|
cherry pick to release-3.0 in PR #15419 |
lysu
added a commit
to sre-bot/tidb
that referenced
this pull request
Mar 17, 2020
jackysp
pushed a commit
that referenced
this pull request
Mar 17, 2020
sre-bot
added a commit
to sre-bot/tidb
that referenced
this pull request
Mar 17, 2020
sre-bot
added a commit
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #15120
PD or TiDB RESTful service will require https when cluster configured with cluster-ssl-*, but tidb-server only can send http request.
What is changed and how it works?
change to https client when "cluster-ssl-*" configured
Check List
Tests
configure pd/tidb/tikv as https://pingcap.com/docs/stable/how-to/secure/enable-tls-between-components/
then try to use TiDB http-api or "cluster table"
Code changes
Side effects
Related changes
Need to cherry-pick to the release branch
Release note
use https request between tidb-pd tidb-tidb when cluster-ssl configured.
This change is