Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: correct the dbName for hint #15319

Merged
merged 5 commits into from
Mar 17, 2020
Merged

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

fix #15318

What is changed and how it works?

Set the correct database name for the hint.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

N/A

Release note

N/A

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Mar 12, 2020
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner March 12, 2020 06:31
@ghost ghost requested review from eurekaka and winoros and removed request for a team March 12, 2020 06:31
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #15319 into master will decrease coverage by 0.0014%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master     #15319        +/-   ##
================================================
- Coverage   80.3872%   80.3857%   -0.0015%     
================================================
  Files           502        502                
  Lines        133714     133714                
================================================
- Hits         107489     107487         -2     
- Misses        17783      17793        +10     
+ Partials       8442       8434         -8

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2020
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

Your auto merge job has been accepted, waiting for 15430

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2020
@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5268094 into pingcap:master Mar 17, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

cherry pick to release-3.0 in PR #15433

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

cherry pick to release-3.1 in PR #15434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inl_hash_join does not work as expected
5 participants