Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,infoschema: move dataForTableConstraints into executor #15240

Merged

Conversation

Rustin170506
Copy link
Member

UCP #15027
Signed-off-by: Rustin-Liu rustin.liu@gmail.com

What problem does this PR solve?

move dataForTableConstraints into executor.

What is changed and how it works?

move dataForTableConstraints into executor.

Check List

Tests

  • Unit test

Code changes

None
Side effects

None

Related changes

None
Release note
None

… to `executor`

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 requested a review from a team as a code owner March 9, 2020 12:23
@sre-bot
Copy link
Contributor

sre-bot commented Mar 9, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 9, 2020
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team March 9, 2020 12:23
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Mar 9, 2020
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #15240 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #15240   +/-   ##
=========================================
  Coverage   80.395%   80.395%           
=========================================
  Files          503       503           
  Lines       133589    133589           
=========================================
  Hits        107399    107399           
  Misses       17778     17778           
  Partials      8412      8412

@Rustin170506
Copy link
Member Author

@zz-jason @lonng PTAL~

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Rustin170506 Rustin170506 requested a review from lonng March 10, 2020 01:11
@Rustin170506
Copy link
Member Author

@zz-jason @lonng ping~

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2020
Copy link
Contributor

@reafans reafans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reafans reafans added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

/run-all-tests

@sre-bot sre-bot merged commit 31469e0 into pingcap:master Mar 10, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 10, 2020

Team Rustin-Liu complete task #15027 and get 50 score, currerent score 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants