Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UCP: Migrate dataForTiDBClusterInfo from package infoschema to executor #15230

Merged
merged 6 commits into from
Mar 11, 2020
Merged

UCP: Migrate dataForTiDBClusterInfo from package infoschema to executor #15230

merged 6 commits into from
Mar 11, 2020

Conversation

yzwqf
Copy link
Contributor

@yzwqf yzwqf commented Mar 9, 2020 •
edited
Loading

What problem does this PR solve?

UCP #15031

What is changed and how it works?

Migrate dataForTiDBClusterInfo from package infoschema to executor.

Check List

Tests

  • Unit test
  • Integration test

@yzwqf yzwqf requested a review from a team as a code owner March 9, 2020 09:31
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 9, 2020
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team March 9, 2020 09:31
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Mar 9, 2020
@zz-jason
Copy link
Member

zz-jason commented Mar 9, 2020 •
edited
Loading

Hi @yzwqf, thanks for your contribution! The failed UT seems is unstable, which is a known issue: #15091. It's under investigation, we'll fix it ASAP.

Also, please sign the CLA so we can get this PR merged.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zz-jason zz-jason requested review from lonng and crazycs520 and removed request for qw4990 and wshwsh12 March 9, 2020 12:37
@codecov
Copy link

codecov bot commented Mar 9, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ea04c6a). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #15230   +/-   ##
===========================================
  Coverage          ?   80.3288%           
===========================================
  Files             ?        503           
  Lines             ?     133063           
  Branches          ?          0           
===========================================
  Hits              ?     106888           
  Misses            ?      17748           
  Partials          ?       8427

@yzwqf
Copy link
Contributor Author

yzwqf commented Mar 9, 2020

Hi @yzwqf, thanks for your contribution! The failed UT seems is unstable, which is a known issue: #15091. It's under investigation, we'll fix it ASAP.

Also, please sign the CLA so we can get this PR merged.

thx, i also try to figure it out

lonng
lonng reviewed Mar 10, 2020
View reviewed changes
executor/infoschema_reader_test.go
@@ -309,3 +326,207 @@ func (s *testInfoschemaTableSuite) TestPartitionsTable(c *C) {

tk.MustExec("DROP TABLE `test_partitions`;")
}

var _ = SerialSuites(&testInfoschemaClusterTableSuite{testInfoschemaTableSuite: &testInfoschemaTableSuite{}})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we realy need to nest the testInfoschemaTableSuite in the testInfoschemaClusterTableSuite ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneccessaryly, just for reuse code like done in the tables_test.go before, it is ok to decouple.

lonng
lonng reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@zz-jason
Copy link
Member

@yzwqf gofmt failed, please run make check in your machine to fix it.

@yzwqf
Copy link
Contributor Author

yzwqf commented Mar 10, 2020

@yzwqf gofmt failed, please run make check in your machine to fix it.

I'm new to git and very depressed, how is it now...

@lonng
Copy link
Contributor

lonng commented Mar 10, 2020 •
edited
Loading

Hi, @yzwqf Seems you do some misoperations on git, maybe you can do the following instructions to pull it back on the right path.

git checkout myfeature
git reset --hard a000858
make fmt
git commit -am 
git push -f

@zz-jason zz-jason requested a review from lonng March 11, 2020 09:04
@zz-jason
Copy link
Member

@yzwqf please resolve the conflicts.

@reafans
Copy link
Contributor

reafans commented Mar 11, 2020

Rest LGTM, Hi @yzwqf, thanks for your contribution. The failed check_dev shows that the code need format, just use make fmt for your changed code and commit them to fix it.

crazycs520
crazycs520 reviewed Mar 11, 2020
View reviewed changes
executor/infoschema_reader_test.go
"github.com/pingcap/tidb/statistics"
"github.com/pingcap/tidb/util/testutil"
"net"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move line #21 ~ #25 after line #18

@reafans
Copy link
Contributor

reafans commented Mar 11, 2020

lgtm

@reafans reafans added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2020
@lonng
Copy link
Contributor

lonng commented Mar 11, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

Your auto merge job has been accepted, waiting for 14651

@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

@yzwqf merge failed.

@lonng
Copy link
Contributor

lonng commented Mar 11, 2020

/run-all-tests

@lonng lonng merged commit a10a2c3 into pingcap:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@lonng lonng lonng approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yzwqf @zz-jason @CLAassistant @lonng @reafans @sre-bot @crazycs520